koji

#1788 koji-gc trashing builds it shouldn't?
Closed: Dropped by alexi. Opened by alexi.

Closed: Dropped
Reopen Issue

We're running koji-gc 1.17.1 and it seems to be trashing builds it's not supposed to. Here's one example, showing a grep through the log file in debug mode:

...
a2ps
tag el6* :: keep
keep: a2ps-4.14-13.el6 (el6, 0)
...
[3/13079] Build has been used in a buildroot: a2ps-4.14-10.1.el6
Last_used: 1321011625.13448
[3/13079] Adding build to trash list: a2ps-4.14-10.1.el6
...
Moving to trashcan: a2ps-4.14-10.1.el6
...

If I understand things correctly, a2ps-4.14-13.el6 is in tag el6 and should be kept, and was also used in a buildroot. Why is it being moved to the trashcan? What am I missing?

In this case, it could have been used in buildroot, but if it was not use longer than --delay which default to five days, it is still eligible for deletion.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

What about the tag policy?

If we're talking about fedora's koji, this build has only dist-6E-epel tag.

Ah, maybe this is misunderstanding. Tag policy is about tags attached to that build, not about build's dist tag.

No, this is on our own koji setup. The build a2ps-4.14-13.el6 is tagged el6 (confusingly the same as the dist tag in this case, yes), and the policy for that tag is to keep. So that build should not lose the el6 tag, and as it's still tagged somewhere it shouldn't be trashed. Is my understanding correct?

Yes, you're correct.

It is weird, if it is still tagged. that "Moving to trashcan" part is triggered only for builds which already doesn't have any tags. If it was untagged by GC, you should see some "Untagging build" line in log. Or you can check brew list-history --build a2ps-4.14-13.el6 what was happening to those tags. If it is still tagged and GC is doing that trashcan ops, the we have a bug somewhere.

@alexi Should I close this ticket?

Sure, let's close it, I can reopen it when I have time to follow this up.

Metadata Update from @alexi:
- Issue close_status updated to: Dropped
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/1788

Please continue any further discussion there.
Metadata
None
None
None
None
Low
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.