koji

#2122 RFE: pass the broot object into the postSCMCheckout callback in i.e. buildSRPMfromSCM task
Closed: Fixed by mikem. Opened by asaleh.

Closed: Fixed
Reopen Issue

As we were developing rpmautospec [0], it would be helpful for us to have all of the utilities present in the buildroot instead of just having access to srcdir.

This hopefully would be a small change in the code, with no breaking changes for the existing plugins.

[0] https://pagure.io/Fedora-Infra/rpmautospec

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.22

I don't think this is easy because the postSCMCheckout would now need to run inside buildroot. But I might be wrong. Just passing buildroot argument does not sound too useful.

Well, it doesn't run anywhere, it is just a callback. The buildroot already is created.

We are currently working on a proof-of-concept that uses broot.mock while referencing the srcdir with broot.path_without_to_within and so far it actually seems to help us :-)

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

PR #2123

Metadata Update from @jcupova:
- Issue tagged with: testing-done

We normally do not pass internal objects to callbacks. On the hub, doing something like this would likely be a non-starter. Here in the builder code, I guess it's ok.

Any plugins that use this should be aware that using this could make them more fragile across releases. This feature does not come with a promise avoid changing the behavior of the BuildRoot class.
Edited by mikem

Commit 44cc51c8 fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/2122

Please continue any further discussion there.
Metadata
None

testing-done testing-ready

None
None
Low
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.