Issue #2321: Give koji admins the permission to remove-side-tag of others - koji

koji

#2321 Give koji admins the permission to remove-side-tag of others

Closed: Fixed Jun 17, 2020 by tkopecek. Opened Jun 16, 2020 by mohanboddu.

Currently, we cannot remove a side-tag created by others, but as koji admins we need to clean up some side tags, maybe the user forgot to remove it or bodhi didn't remove it for any reason or kojira is not working properly as it supposed to...

It would be great to grant koji admins to allow removing of side tags created by others.

nphilipp commented Jun 16, 2020

The is_sidetag_owner() function in the sidetag_hub plugin seems to be the culprit, it doesn't take into account whether the user has admin permissions or not. I'll write a patch.

Edited Jun 16, 2020 by nphilipp

nphilipp commented Jun 16, 2020

PR containing a fix: #2322

Metadata Update from @tkopecek:
- Custom field Size adjusted to None
- Issue set to the milestone: 1.22
- Issue tagged with: bug, testing-ready

Jun 17, 2020

tkopecek commented Jun 17, 2020

Commit 474f346d fixes this issue

tkopecek commented Jun 17, 2020

Commit cad3e63e fixes this issue

tkopecek commented Jun 18, 2020

Commit 64147a33 fixes this issue

tkopecek commented Jun 18, 2020