#3141 kojira still fails on deleted tag
Closed: Insufficient data by mikem. Opened by tkopecek.

2936 fixed one case, it looks there is at least one more:

2021-11-20 15:28:28,066 [ERROR] koji.repo.regen: Error in regen thread
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/koji/__init__.py", line 2746, in _callMethod
    args = encode_args(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/koji/__init__.py", line 2661, in _sendCall
    request = request.encode('utf-8')
  File "/usr/lib/python3.6/site-packages/koji/__init__.py", line 2710, in _sendOneCall
    try:
  File "/usr/lib/python3.6/site-packages/koji/__init__.py", line 2722, in _read_xmlrpc_response
    try:
  File "/usr/lib64/python3.6/xmlrpc/client.py", line 656, in close
    raise Fault(**self._stack[0])
xmlrpc.client.Fault: <Fault 1000: "No such tagInfo: 'deleted_tag'">

The (outer) traceback here is:

Traceback (most recent call last):
  File "/usr/sbin/kojira", line 599, in regenLoop
    self.regenRepos()
  File "/usr/sbin/kojira", line 1002, in regenRepos
    if koji.util.multi_fnmatch(tagname, debuginfo_pat):
  File "/usr/lib/python3.6/site-packages/koji/__init__.py", line 2319, in __call__
    class VirtualMethod(object):
  File "/usr/lib/python3.6/site-packages/koji/__init__.py", line 2765, in _callMethod
    # should be read-only and hence retryable.
koji.GenericError: No such tagInfo: 'deleted_tag'

Metadata Update from @mikem:
- Custom field Size adjusted to None

The kojira log tracebacks are a little confusing. On the hub side, it looks like this is happening in a newRepo call

[WARNING] m=newRepo u=kojira koji.xmlrpc: Traceback (most recent call last):
  File "/usr/share/koji-hub/kojixmlrpc.py", line 253, in _wrap_handler
    response = handler(environ)
  File "/usr/share/koji-hub/kojixmlrpc.py", line 277, in handle_rpc
    return self._dispatch(method, params)
  File "/usr/share/koji-hub/kojixmlrpc.py", line 314, in _dispatch
    ret = koji.util.call_with_argcheck(func, params, opts)
  File "/usr/lib/python3.6/site-packages/koji/util.py", line 271, in call_with_argcheck
    return func(*args, **kwargs)
  File "/usr/share/koji-hub/kojihub.py", line 12453, in newRepo
    get_tag(tag, strict=True, event=event)
  File "/usr/share/koji-hub/kojihub.py", line 3447, in get_tag
    raise koji.GenericError("No such tagInfo: %r" % tagInfo)
koji.GenericError: No such tagInfo: 'deleted_tag'

The newRepo call is just after these multi_fnmatch checks in regenRepos(), so seems like python is doing something odd with the traceback :confused:

The GenericError traceback doesn't make sense to me because I don't see how if koji.util.multi_fnmatch(tagname, debuginfo_pat): is making a hub call at all. There's only one place in kojira where we make a newRepo call to the hub and while it's near this line, it isn't nested under it.

Apparently the trigger for this was not a deleted tag, but a renamed one.

Either way, I am so far unable to replicate it locally.

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.29 (was: 1.28)

Metadata Update from @tkopecek:
- Issue set to the milestone: None (was: 1.29)

The regen portion of kojira was completely rewritten in #4033. I was never able to replicate this, but the code from the traceback is no longer in Koji.

The new Kojira can handle deleted and renamed tags without an error, but then afaict the old one could too.

I'm going to close this. Reopen if it happens with the new code.

Metadata Update from @mikem:
- Issue close_status updated to: Insufficient data
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3141

Please continue any further discussion there.

Metadata