koji

#3673 editing rpm macros in sidetag should be based on allowed list
Closed: Fixed by tkopecek. Opened by tkopecek.

Closed: Fixed
Reopen Issue

Followup of #3669

First, we can't call it a "whitelist", but also why? What's the rationale for this? Even OBS doesn't have this.

@ngompa https://pagure.io/releng/issue/11254

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Okay, I suppose. As long as we also allow side tags to be configured for any macro too. This would make it possible to simplify modular builds by eliminating the need for generating weird module-rpm-macros packages that are effectively untraceable and allowing us to encode the macros for a module build into a side-tag that Koji "knows" forever.

It is still there - if you just put there "1" or "True", it will allow anything. If there is a list, it means that only those are allowed.

PR #3674

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @relias-redhat:
- Issue untagged with: testing-ready

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Commit c82543a6 fixes this issue

Commit 8e0bdd7a relates to this ticket

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3673

Please continue any further discussion there.
Metadata
None

testing-done testing-ready

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.