koji

#3793 getSessionInfo returns fewer items when user_id is used than default
Closed: Fixed by tkopecek. Opened by jcupova.

Closed: Fixed
Reopen Issue

When we run getSessionInfo as default or with details, there is update_time, update_ts, start_time, start_ts. But when we run getSessionInfo with user_id, it returns start_time (but value is start_ts) and update_time. It would be better to unify it.

PR 3794

Metadata Update from @jcupova:
- Custom field Size adjusted to None

The getSessionInfo call is kind of a mess. In addition to the field variations noted, we also have variation in return type (list vs dict or None), and the behavior of each case depends on two very separate bits of code with different purposes.

While koji itself only uses this call only two places and we could probably manage to make these fields consistent without breaking those cases, I'm still a little concerned about breaking the api here. Another tool could be relying on these fields being as they are.

My point here is to not rush into an incompatible change.

For reference, the polymorphism in getSessionInfo was introduced fairly recently in #3446, which was part of version 1.31. Before that, the call simply returned context.session.session_data

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.34 (was: 1.33)

Commit a40ce211 fixes this issue

Commit 48b34b46 fixes this issue

Metadata Update from @relias-redhat:
- Issue status updated to: Open (was: Closed)

Metadata Update from @relias-redhat:
- Issue tagged with: testing-ready

Metadata Update from @relias-redhat:
- Issue tagged with: testing-done

Commit 7f177a04 fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3793

Please continue any further discussion there.
Metadata
None

testing-done testing-ready

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.