#3990 tests failing because requirements are missing
Closed: Duplicate by tkopecek. Opened by alisboav.

The tox.ini is missing dependencies - requirements.txt - for the [testenv:py3] and [testenv:py2]

The tests are failing with:

==================================== ERRORS ====================================
________ ERROR collecting tests/test_builder/test_build_notification.py ________
ImportError while importing test module '/builds/linuxsupport/rpms/koji/build/BUILD/koji-1.34.0/tests/test_builder/test_build_notification.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.6/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_builder/test_build_notification.py:15: in <module>
    from .loadkojid import kojid
tests/test_builder/loadkojid.py:13: in <module>
    spec.loader.exec_module(kojid)
builder/kojid:63: in <module>
    import Cheetah.Template
E   ModuleNotFoundError: No module named 'Cheetah'

Only test-requirements.txt dependencies are being installed:

py3 installdeps: -r/builds/linuxsupport/rpms/koji/build/BUILD/koji-1.34.0/test-requirements.txt

and with the previous release, both files were taken into account:

py3 installdeps: -r/builds/linuxsupport/rpms/koji/build/BUILD/koji-1.33.1/requirements.txt, -r/builds/linuxsupport/rpms/koji/build/BUILD/koji-1.33.1/test-requirements.txt

I will send a PR to fix this issue for py2 and py3 env.


https://pagure.io/koji/pull-request/3991

Hi @alisboav , this issue should fix this PR also. https://pagure.io/koji/pull-request/3992

Metadata Update from @jcupova:
- Custom field Size adjusted to None

Metadata Update from @tkopecek:
- Issue close_status updated to: Duplicate
- Issue status updated to: Closed (was: Open)

Duplicate #3868

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3990

Please continue any further discussion there.

Metadata
Related Pull Requests