koji

#101 Added CG_Importer tests
Merged by mikem. Opened by jvasallo.
jvasallo/koji master  into  master

Download 101.patch

Working through test cases of CG_Importer, so far so good. Only change I did was adding unicode with @threebean to hub/kojihub.py for lookup_name. Might want to review this in the future for better serialization.

woot!

1 new commit added

  • Added test cases for get_build

side note: please be careful about submitting PRs from your master branch. Pagure will auto-update the PR if that branch changes

should we use koji.fixEncoding() here?

Thanks for the feedback mikem. Was a WIP while I was at PyCon this past weekend, forgot to branch off.

Ill look into koji.fixEncoding() as you suggested. This part was a debated part as I was under the impression some refactoring on koji might happen soon. I could also make it a TODO comment until we can determine a long term solution.

A couple minor things
* adds trailing whitespace on two lines
* invalid comment seemingly copied from PR#93

E.g. https://github.com/mikem23/koji-playground/commits/cg-importer-tests

I'm slightly concerned that the 'elif isinstance(info, unicode)' case doesn't show up as covered by the test. I assume you added it because you ran into an issue, so surprised the test case doesn't hit it.

Apologies for the delay on this pull request. I am still playing post PyCon catchup at work. I hope to tiddy up the request tonight! Thanks for the feedback, and yes, I did run into an issue requiring to check for unicode, but ill double check to make sure its tested (if I added it, I'd better make sure its tested).

1 new commit added

  • Leveraging koji.fixEncoding() and cleaned up spacing

Commit f3a8d6e1 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.