koji

#1185 Unit tests download_file with errors status code
Closed by mikem. Opened by jcupova.
jcupova/koji unit-test-download-file  into  master

Download 1185.patch

Add unit tests for download_file for non-existing file and internal server error.

@mikem I've recommended using requests_mock module. In some subsequent PR I would like to replace manually mocked requests calls with this library, which is more convenient for thinks like status_code, etc.

:thumbsup:

We'll need to update docs/source/writing_koji_code.rst to indicate the addition requirements for running unit tests.

Also similar for docs/source/configuring_jenkins.rst (as well as applying for our jenkins, not the failure to the side).

I've added docs in PR #1223

pretty please pagure-ci rebuild

:thumbsup:

Merging #1223, which includes these changes.

Pull-Request has been closed by mikem
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.