#148 add pre/postCommit callback
Merged by mikem. Opened by mikem.
https://github.com/mikem23/koji-playground.git master

Download 148.patch
no initial comment

Simply add pre/postCommit callbacks on the hub

Resolves issue #147

actually, just realized, that this in isolation will have the default messagebus plugin forwarding these. Not sure if that will break, or cause confusion

1 new commit added

  • don't generate messages on postCommit events

@mikem That's gonna be a lot of extra, irrelevant messages on the bus. We probably want to update the messagebus plugin to ignore postCommit (or maybe any callback that provides no args or kws).

Nice! fedmsg plugin preemptively modified to drop postCommit events here: https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=1aea17126e400da4bb29ffd7d157899c833e11ed

Pull-Request has been merged by mikem

Metadata