New options --wait-for-build and --wait-for-repo for build command are simplification of using wait-repo + build command succession. They have same semantices as the original one.
Fixes: https://pagure.io/koji/issue/1619
It is builder-side alternative to PR #1624
ping @breilly @julian8628
@mizdebsk @jkaluza wdyt?
:thumbsup:
One more ping before merging: @julian8628 @ignatenkobrain @mizdebsk @jkaluza @mikem
Metadata Update from @tkopecek: - Pull-request tagged with: testing-ready
IMO this PR duplicates already-existing feature - chain build already implements this functionality, it can spawn waitrepo task that will wait for build repo containing specified build(s) before build task is created. For example: https://koji.kjnet.xyz/koji/taskinfo?taskID=28567
It is very similar. I think, that major difference is waiting for 'actual' repo without specifying required build. But maybe, that chainbuild is better place to put this option.
rebased onto d036d3dd063e082e2debe60e19f43378d2a25f5f
rebased onto d4192ba53d5e631a8b9b73e3dfcc3c2e5cdd1ac8
rebased onto 743434b6ae8ed49cf5896cf4bd0c3cfdd9b916e6
rebased onto ba4705327a139c885ea15002000c85486c2f122f
Metadata Update from @tkopecek: - Pull-request untagged with: testing-ready
@julian8628 @mizdebsk Do you think, it would be better to limit this one to --wait-repo only and leave --wait-builds behaviour for chainbuild?
--wait-repo
--wait-builds
chainbuild
I think both options are useful if users don't want to use the more complex chain-build. And chain-build aims more to build all of the builds with deps. Not sure if just waiting for a build which is being built by other ones before building a build is a case here, But build --wait-builds can handle this as well.
chain-build
build --wait-builds
Commit 062050c8 fixes this pull-request
Pull-Request has been merged by tkopecek
Metadata Update from @jcupova: - Pull-request tagged with: testing-done
New options --wait-for-build and --wait-for-repo for build command are
simplification of using wait-repo + build command succession. They have
same semantices as the original one.
Fixes: https://pagure.io/koji/issue/1619