koji

#2082 delete oldest failed buildroot, when there is no space
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue1913  into  master

Download 2082.patch

Fixes: https://pagure.io/koji/issue/1913

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

1 new commit added

  • add real delete

1 new commit added

  • delete main part of data

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

elif age > 120 or not self.checkSpace():

It's not clear to me why we need to change this condition. It's at least worth a comment.

I think this 2 minute barrier may be a protection against a race condition. Are we worried that 2 minutes is too long for an old buildroot to persist?
Edited by mikem

Ah, it is probably not needed now. I've added that check, while Martin tested it. But it showed as a false alarm. (removing)

1 new commit added

  • remove unneeded condition

:thumbsup:

Do we need to re-test?

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-done

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Commit b972b572 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.