#2388 change getRPMHeaders default to fetching all headers if none are otherwise supplied
Merged by tkopecek. Opened by cobrien.
cobrien/koji all_headers  into  master

Download 2388.patch

This is a preliminary PR to start discussion off on allowing the getRPMHeaders hub call to default to all headers when none are specified explicitly.

This adds special treatment to a sentinel None value for the headers parameter to get_header_fields. An empty list would still be treated as if no headers were specified. To this end, the conversion of None to an empty list is therefore removed from the beginning of the getRPMHeaders call.

It may seem strange to support the call wanting no data back, but as that's the current default behavior anyway, I think that's fine.

Potential problems: is rpm.tagnames available in historic copies of the rpm library? It's in at least the RHEL 6 version.

@julian8628 per conversation on IRC today

Even rhel5 (py 2.4 + rpm 4.4) supports this. I would be ok with including this change.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Issue #2389

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done

Commit aa8f0f3e fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata