PR#246: Revert "default krb_rdns to True" -

koji

#246 Revert "default krb_rdns to True"

Merged Dec 19, 2016 by mikem. Opened Dec 17, 2016 by till.

till/koji koji_gc into master

till commented Dec 17, 2016

This reverts commit 02128ee5777b560619314cc0220e1ed7ca16b28c.

The second column in cfgmap is an alias and "True" is not a valid alias.
It was mistaken in the reverted commit as a default value, which it is
not. Reverting this commit should fix the following traceback that
koji-gc in Fedora currenty raises:

Traceback (most recent call last):
File "/usr/sbin/koji-gc", line 901, in
options, args = get_options()
File "/usr/sbin/koji-gc", line 159, in get_options
if config.has_option(*alias):
TypeError: has_option() argument after * must be a sequence, not bool

1 new commit added

koji-gc: Set default value for krb_rdns to True

Dec 18, 2016

2 new commits added

koji-gc: Set default value for krb_rdns to False
Revert "default krb_rdns to True"

Dec 18, 2016

2 new commits added

koji-gc: Set default value for krb_rdns to False
Revert "default krb_rdns to True"

Dec 18, 2016

tkopecek commented Dec 19, 2016

Can you also expand comment (line 129), so it is more clear, that values in list are aliases' names, not the default values? Just to have it in same PR.

tkopecek commented Dec 19, 2016

+1 anyway :-)

tkopecek commented Dec 19, 2016

Affects #244

mikem commented Dec 19, 2016

Commit 5da75e16 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Dec 19, 2016

till commented Dec 19, 2016

Thank you - the better comment is a good idea, I filed #257 for this.