#2826 Add kerberos debug message
Merged by tkopecek. Opened by jcupova.
jcupova/koji issue-2063  into  master

Download 2826.patch

Fixes: https://pagure.io/koji/issue/2063

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

python seems redundant here

I don't know if this really helps. It directs users to run "koji", which is not really applicable for commands where that's symlinked or aliased to something else.

I think we should update this PR to stop logging this at "debug" level and make it "error" level.

I think the biggest change we should make here would be to update AuthError to mention the authentication type, and then add a document that describes "how to troubleshoot Kerberos authentication" with a walkthrough.

One problem is that Koji catches a base Exception class here, and then we hide that information behind the "-d" flag. It's more work for the user to re-run with "-d".

Catching the base Exception and then raising a single AuthError is not great. If this were entirely new code it would be great to simply raise the original exception here, but I understand there are some API considerations here (because clients might expect to catch AuthError).

What if we we sub-class AuthError to something like GSSAPIAuthError and include the error message from requests-gssapi in that?

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready

rebased onto f75fed4bad85df5fc44e226fb46046b05b1c98d6

rebased onto 5509c7b06177e1df15ce05c050d5cd3e4cff3a84

rebased onto 54fcb941cbb458a92467dda6d94a38c6eb815c8c

rebased onto 0a9fe6cbe3afc3819745640378b38ee9b4bc63c0

rebased onto a446cdf88e89a224b827e5994adc9e68994d7a43

Extended docs: https://pagure.io/fork/tkopecek/koji/commits/pr2826a

1 new commit added

  • doc: extend gssapi debug docs

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @jobrauer:
- Pull-request tagged with: testing-done

Commit d83c1524 fixes this pull-request

Pull-Request has been merged by tkopecek

Metadata