From 368d727dc7f777b295e4731db1fe97e1fcc1fe98 Mon Sep 17 00:00:00 2001
From: Aron Parsons <aron@knackworks.com>
Date: Mar 05 2017 19:09:06 +0000
Subject: smtplib requires connect() call


behavior seen in koji-utils-1.11.0-1.el7.noarch

Traceback (most recent call last):
  File "/sbin/koji-gc", line 921, in <module>
    rv = main(args)
  File "/sbin/koji-gc", line 430, in main
    globals()['handle_' + x]()
  File "/sbin/koji-gc", line 538, in handle_trash
    send_warning_notice(owner_name, [x[1] for x in builds])
  File "/sbin/koji-gc", line 423, in send_warning_notice
    s.sendmail(msg['From'], msg['To'], msg.as_string())
  File "/usr/lib64/python2.7/smtplib.py", line 722, in sendmail
    self.ehlo_or_helo_if_needed()
  File "/usr/lib64/python2.7/smtplib.py", line 541, in ehlo_or_helo_if_needed
    if not (200 <= self.ehlo()[0] <= 299):
  File "/usr/lib64/python2.7/smtplib.py", line 412, in ehlo
    self.putcmd(self.ehlo_msg, name or self.local_hostname)
  File "/usr/lib64/python2.7/smtplib.py", line 340, in putcmd
    self.send(str)
  File "/usr/lib64/python2.7/smtplib.py", line 332, in send
    raise SMTPServerDisconnected('please run connect() first')
smtplib.SMTPServerDisconnected: please run connect() first

---

diff --git a/util/koji-gc b/util/koji-gc
index d474ce4..adee349 100755
--- a/util/koji-gc
+++ b/util/koji-gc
@@ -421,6 +421,7 @@ refer to the document linked above for instructions."""
             print("Sending warning notice to %s" % msg['To'])
         try:
             s = smtplib.SMTP(options.smtp_host)
+            s.connect()
             s.sendmail(msg['From'], msg['To'], msg.as_string())
             s.quit()
         except: