From 8fc27c848297f9d3f29e219cea1ac7a9f426971a Mon Sep 17 00:00:00 2001 From: Patrick Uiterwijk Date: Jun 29 2022 08:59:30 +0000 Subject: Fix rpm_hdr_size file closing The current code will try to close a passed in file object, and will not try to close a file object it opened when a string is passed in. This results in either a leaked file object, or a file object that was passed in to be closed after the function is called. Signed-off-by: Patrick Uiterwijk --- diff --git a/koji/__init__.py b/koji/__init__.py index 55f9c43..7edbab9 100644 --- a/koji/__init__.py +++ b/koji/__init__.py @@ -648,7 +648,7 @@ def rpm_hdr_size(f, ofs=None): # add eight bytes for section header hdrsize = hdrsize + 8 - if not isinstance(f, six.string_types): + if isinstance(f, six.string_types): fo.close() return hdrsize