I'm not sure if this is the right place for this. The schema files are a bit of an oddity. They don't really belong with the hub, but our packaging doesn't give us many options. The main place we need them is on the db host, which is not necessarily the same host as the hub.

If you are running a separate db host, as is common, then you'd either need to install koji-hub or manually copy these over. Installing just the base koji package was a smaller impact.

Alternatives:

• leave them in the main koji package, but not as docs (so, likely new location)
• move them to the hub package as here, but not under /usr/share/koji-hub

/usr/share/koji? If yes, I'll update paths in migration docs, etc.

 %files
 %config(noreplace) /etc/koji.conf
 %dir /etc/koji.conf.d
-%doc docs Authors COPYING LGPL
+%doc docs/source Authors COPYING LGPL
+%{_datadir}/koji/*.sql

As a side effect of this, we're changing the location for packaged docs, from /usr/share/doc/koji/docs/source/ to /usr/share/doc/koji/source/. Also we are no longer packaging the docs Makefile.

The first is probably ok. The previous "docs" subdir seems extraneous, but maybe we ought to at least include a symlink docs → . to avoid breaking paths.

The second is probably ok. I doubt anyone is trying to build the docs from the installed package.

OTOH, perhaps it would make sense to move these files out of docs/ in the source since they are being handled and packaged differently. This would naturally avoid any package changes to the other docs, but otoh I suspect we have QE scripts would need to have updated paths.

wdyt?

Created migrations directory. Maybe some better name/location?

Created migrations directory. Maybe some better name/location?

Since the files aren't all migrations, perhaps just call this dir schemas

The spec is still calling make install for the docs dir, but it doesn't do anything anymore.

Do we want package docs/source, or go back to packaging docs? The latter is less change, though there isn't much directly in the docs dir anymore.

If the former, easier to put the docs→. symlink under docs/source so we don't have to list it separately. If the latter, the we don't need the symlink (though maybe add a README.schema about the relocated schema files). All else being equal, I think I'd err on less change (so the latter).

lgtm

Commit cda3163d fixes this pull-request