PR#4145: report tag_external_repos.arches in query_history - koji

koji

#4145 report tag_external_repos.arches in query_history

Opened 7 months ago by mikem. Modified 7 hours ago

mikem/koji history-ext-repo-arches into master

unit test

Mike McLean • 7 months ago

2e8bb23

report tag_external_repos.arches in query_history

Mike McLean • 7 months ago

1f217e3

kojihub/kojihub.py

file modified

+1 -1

		`@@ -8588,7 +8588,7 @@`
		`'external_repo_data': ['external_repo_id', 'data'],`
		`'host_config': ['host_id', 'arches', 'capacity', 'description', 'comment', 'enabled'],`
		`'host_channels': ['host_id', 'channel_id'],`
		`- 'tag_external_repos': ['tag_id', 'external_repo_id', 'priority', 'merge_mode'],`
		`+ 'tag_external_repos': ['tag_id', 'external_repo_id', 'priority', 'merge_mode', 'arches'],`
		`'tag_listing': ['build_id', 'tag_id'],`
		`'tag_packages': ['package_id', 'tag_id', 'blocked', 'extra_arches'],`
		`'tag_package_owners': ['package_id', 'tag_id', 'owner'],`

tests/test_hub/test_query_history.py

file modified

		`@@ -455,6 +455,7 @@`
		`self.assertEqual(query.tables, ['tag_external_repos'])`
		`self.assertEqual(query.clauses, ['external_repo.id = %(external_repo_id)i'])`
		`self.assertEqual(query.columns, ['tag_external_repos.active',`
		`+ 'tag_external_repos.arches',`
		`'tag_external_repos.create_event',`
		`"date_part('epoch', ev1.time) AS create_ts",`
		`'tag_external_repos.creator_id', 'creator.name',`

mikem commented 7 months ago

This fixes an oversight in query_history. The arches field of this table was omitted. This field was added to the table in #2564 (from 1.24)

Fixes https://pagure.io/koji/issue/4290

tkopecek commented 7 months ago

Do we want to pull it into 1.35 as part of repo regen rewrite?

mikem commented 7 months ago

I don't think it's needed for 1.35. I just happened to notice this while poking at some history calls last week. I don't think any part of the kojira code relies on query_history.

This is a very small and safe change, so it would be ok to pull it in in principle, but I wouldn't want to hold up 1.35 for it.