koji

Clone

#4333 disable strict_parsing of parse_qs
Closed a month ago by mikem. Opened 2 months ago by alisboav.
alisboav/koji issue-4332  into  master

file modified
+1 -1 
@@ -211,7 +211,7 @@ 
 

      """Emulate the parts of cgi.FieldStorage that we need"""
 

  

      def __init__(self, environ):
 

-         data = parse_qs(environ.get('QUERY_STRING', ''), strict_parsing=True,
 

+         data = parse_qs(environ.get('QUERY_STRING', ''), strict_parsing=False,
 

                          keep_blank_values=True)
 

          # replace singleton lists with single values
 

          for arg in data:

Disabling strict parsing is not the right fix here. Kojiweb has always errored on invalid args. The issue here is that blank args should not be invalid.

Alternate approach in #4334

Pull-Request has been closed by mikem
a month ago
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
www/lib/kojiweb/util.py
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.