PR#4349: Raise weight cap - koji

koji

#4349 Raise weight cap

Merged 17 days ago by tkopecek. Opened 2 months ago by tkopecek.

tkopecek/koji drop-limit into master

Raise weight cap

Tomas Kopecek • 2 months ago

a8a6587

builder/kojid

file modified

+2 -2

		`@@ -1593,8 +1593,8 @@`
		`return`
		`# increase the task weight by 0.75 for every hour of build duration`
		`adj = avg / 4800.0`
		`- # cap the adjustment at +4.5`
		`- weight = self.weight() + min(4.5, adj)`
		`+ # cap the adjustment at +18 (24 hours)`
		`+ weight = self.weight() + min(18.0, adj)`
		`self.session.host.setTaskWeight(self.id, weight)`

		`def checkHost(self, hostdata):`

tkopecek commented 2 months ago

Currently weight is limited to 4.5. As they are now builders with very
different setups (number of cpus/memory) it seems to be better to not
limit it and leave it to fill larger builders capacities.

tkopecek commented 2 months ago

@mikem what do you think?

mikem commented 2 months ago

The logic is old and flawed to begin with, so there's no real fix here without a lot of work.

I'd be hesitant to make it completely unbounded, but we could raise the limit much higher. The 4.5 value corresponds to a 6 hour average duration. 18.0 would be 24 hrs.

rebased onto 6113ef7

2 months ago

tkopecek commented 2 months ago

updated to 18

rebased onto 6113ef7

2 months ago

mikem commented 2 months ago

wfm

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-basic

2 months ago