koji

#589 fix scratch ref for scm callback
Merged by mikem. Opened by mikem.
mikem/koji fix-scratch-ref-for-callback  into  master

Download 589.patch

sort of a follow up to #587

:thumbsup:
But, are self.opts and opts the same things here?

But, are self.opts and opts the same things here?

They are not, which is why the fix is needed. The BaseTaskHandler class sets self.opts to the keyword arguments of the call. Some subclasses reassign it later, but not this one. In this case, opts == self.opts['opts'] (that is, assuming opts was passed as a keyword argument and not as the third positional argument).

Thanks @mikem
That makes sense.

Commit c9719ace fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
Metadata
julian8628
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.