PR#65: package builder plugins - koji

koji

#65 package builder plugins

Merged 9 years ago by mikem. Opened 9 years ago by mikem.

https://github.com/mikem23/koji-playground.git builder-plugins into master

plugin conf files should be config(noreplace)

Mike McLean • 9 years ago

05330a2

package builder plugins

Mike McLean • 9 years ago

3bb2c0e

koji.spec

file modified

+19 -1

		`@@ -67,6 +67,17 @@`
		`%description hub-plugins`
		`Plugins to the koji XMLRPC interface`

		`+ %package builder-plugins`
		`+ Summary: Koji builder plugins`
		`+ Group: Applications/Internet`
		`+ License: LGPLv2`
		`+ Requires: %{name} = %{version}-%{release}`
		`+ Requires: %{name}-hub = %{version}-%{release}`
		`+ Requires: python-qpid >= 0.7`
		`+`
		`+ %description builder-plugins`
		`+ Plugins for the koji build daemon`
		`+`
		`%package builder`
		`Summary: Koji RPM builder daemon`
		`Group: Applications/System`
		`@@ -192,7 +203,14 @@`
		`%dir %{_prefix}/lib/koji-hub-plugins`
		`%{_prefix}/lib/koji-hub-plugins/.py`
		`%dir %{_sysconfdir}/koji-hub/plugins`
		`- %{_sysconfdir}/koji-hub/plugins/*.conf`
		`+ %config(noreplace) %{_sysconfdir}/koji-hub/plugins/*.conf`
		`+`
		`+ %files builder-plugins`
		`+ %defattr(-,root,root)`
		`+ %dir %{_sysconfdir}/kojid/plugins`
		`+ %config(noreplace) %{_sysconfdir}/kojid/plugins/*.conf`
		`+ %dir %{_prefix}/lib/koji-builder-plugins`
		`+ %{_prefix}/lib/koji-builder-plugins/.py`

		`%files utils`
		`%defattr(-,root,root)`

no initial comment

mikem commented 9 years ago

Specfile changes necessary because of PR#63
https://pagure.io/koji/pull-request/63

ausil commented 9 years ago

I think we should just put the in koji-builder

mikeb commented 9 years ago

We should mark %{_sysconfdir}/kojid/plugins/*.conf as %config(noreplace).

mikem commented 9 years ago

We should mark %{_sysconfdir}/kojid/plugins/*.conf as %config(noreplace).

Sure, I missed because I started from a copy of %files hub-plugins, so we should fix it there as well.

I'll update that patch shortly

mikem commented 9 years ago

I think we should just put the in koji-builder

I was mirroring the way we handle hub plugins.

One reason to have them separate is to avoid having the base builder package include all the deps. At the moment, there aren't any extra deps for the single plugin we have, but that could easily change in the future.