#730 add unit test for cli commands, coverage(40%)
Merged by mikem. Opened by franzh.
franzh/koji issue729  into  master

Download 730.patch

Continue improve koji cli commands' coverage. (34% -> 40%)

:thumbsup:

rebased onto 0c9e429af152e2fa1ab318cfc8ce1109afccea1a

:thumbsup:

exact same expression for both branches?

minor:

 git diff master... |flake8 --diff
tests/test_cli/test_block_group.py:5:1: F401 'unittest' imported but unused

rebased onto d08a9ffe2aae2f3d57c395aa98ffa90a1e4f89e4

(Dec. 19) Add new unit tests for above commands:

  image-build-indirection
  tag-build
  move-build
  regen-repo
  wait-repo

coverage rate: 46%

minor:
git diff master... |flake8 --diff
tests/test_cli/test_block_group.py:5:1: F401 'unittest' imported but unused

removed, thanks! ;)

3 new commits added

  • add unit tests for cli commands, coverage(46%)
  • improve coverage rate in existing test cases.
  • add unit test for cli commands, coverage(40%)

Modify _printable_unicode unit test in test_hello.py.
Now it only checks unicode string convert.

rebased onto 00c21e8be618e29140414c55900d4b03d9afb3b0

Commit 34af33b8 fixes this pull-request

Pull-Request has been merged by mikem

Metadata