So, this has been sitting here for 10 months? Here's a first stab at a review:

@parasense, there are a number of odd comments in the functions that don't quite make sense to me. (For instance in set_delta). Are they supposed to be a kind of dialogue with the comments from the other MetadataOld class? If so, maybe those could be cleaned up to explain why we can't do such and such thing instead of just stating that we can't.

Is there a reason why we can support createrepo_c for MetadataOld_c, but not also implement a MetadataNew_c class as well? If not, that's probably okay. It would just be good to have a record of the thinking on why.

Lastly, this whole section might benefit from some class inheritance. A number of the methods from MetadataOld_c just got copied over. Perhaps you could extend it instead and only reimplement the methods that you need to... to reduce code duplication.

we'll be killing off the use of mash and moving it to signed repos in koji before F-24 beta

OK. Then in a few months let's circle back here and close all the issues and PRs and update the README to shut down shop.

Tracking signed repos in koji over here.

@ralph @pbrobinson mash never got killed. Please revisit this.

Digging into this, we found that "dist repos" support got merged over here: https://pagure.io/koji/pull-request/318

Digging into this, we found that "dist repos" support got merged over here: https://pagure.io/koji/pull-request/318

Indeed