PR#100: Remove more sqlalchemy references - mdapi

mdapi

#100 Remove more sqlalchemy references

Merged 5 years ago by pingou. Opened 5 years ago by qulogic.

qulogic/mdapi de-sqlalchemy into master

Switch spec file from sqlalchemy to aiosqlite.

Elliott Sales de Andrade • 5 years ago

9a44f1a

Remove last vestiges of sqlalchemy.

Elliott Sales de Andrade • 5 years ago

f798e89

mdapi.spec

file modified

+2 -2

		`@@ -10,18 +10,18 @@`
		`BuildArch: noarch`

		`BuildRequires: python3-aiohttp`
		`+ BuildRequires: python3-aiosqlite`
pingou commented 5 years ago This is true but I don't think aiosqlite is packaged yet which renders the spec invalid. On the other side, it's already invalid since mdapi will no longer work with sqlalchemy.
		`BuildRequires: python3-requests`
		`BuildRequires: python3-setuptools`
		`- BuildRequires: python3-sqlalchemy`
		`BuildRequires: python3-werkzeug`
		`BuildRequires: python3-devel`
		`BuildRequires: systemd`

		`Requires: python3-aiohttp`
		`+ Requires: python3-aiosqlite`
		`Requires: python3-multidict`
		`Requires: python3-requests`
		`Requires: python3-setuptools`
		`- Requires: python3-sqlalchemy`
		`Requires: python3-werkzeug`

		`Requires(post): systemd`

mdapi/default_config.py

file modified

-7

		`@@ -48,11 +48,4 @@`
		`'level': 'INFO',`
		`'handlers': ['console'],`
		`},`
		`- 'loggers': {`
		`- 'sqlalchemy': {`
		`- 'handlers': ['console'],`
		`- 'level': 'WARN',`
		`- 'propagate': False`
		`- }`
		`- }`
		`}`

tests/test_mdapi_data.py

file modified

-1

		`@@ -35,7 +35,6 @@`
		`import mock`
		`import pytest`
		`from aiohttp import web`
		`- from sqlalchemy.exc import SQLAlchemyError`

		`sys.path.insert(0, os.path.join(os.path.dirname(`
		`os.path.abspath(__file__)), '..'))`

qulogic commented 5 years ago

Only aiosqlite and sqlite3 are used directly.

pingou commented on line 5 of mdapi.spec 5 years ago

This is true but I don't think aiosqlite is packaged yet which renders the spec invalid.
On the other side, it's already invalid since mdapi will no longer work with sqlalchemy.

rebased onto f798e89

5 years ago

pingou commented 5 years ago

Based on the fact that this is more correct and in fact not making things worst, let's get this in :)

Thanks!