mdapi

Clone
Source Code
GIT

#47 Specify in the README that the virtualenv must be py3
Merged 8 years ago by pingou. Opened 8 years ago by pingou.
fix_doc  into  master

file modified
+1 -1 
@@ -24,7 +24,7 @@ 
 

  

  ::
 

  

-     mkvirtualenv mdapi
 

+     mkvirtualenv mdapi -p python3
 

  

  * Install the dependencies

file added
+19 
@@ -0,0 +1,19 @@ 
 

+ """ This is an example mdapi configuration for fedmsg.
 

+ By convention, it is normally installed as ``/etc/fedmsg.d/mdapi.py``
 

+ 

+ For Fedora Infrastructure this file is not needed as we use dynamic
 

+ fedmsg endpoints.
 

+ """
 

+ 

+ import socket
 

+ 

+ 

+ hostname = socket.gethostname().split('.')[0]
 

+ 

+ config = dict(
 

+     endpoints={
 

+         "mdapi.%s" % hostname: [
 

+             "tcp://127.0.0.1:3005",
 

+         ],
 

+     },
 

+ )

file modified
+1 -1 
@@ -1,5 +1,5 @@ 
 

  aiohttp
 

+ fedmsg[all]

I'm not familiar with the [all] notation - what does this do?

It installs all the fedmsg requirements: https://github.com/fedora-infra/fedmsg/blob/develop/setup.py#L95

 
  requests
 

  sqlalchemy
 

  werkzeug
 

- fedmsg

no initial comment

1 new commit added

  • Add a fedmsg.d/mdapi.py file so it helps working in a venv
8 years ago

1 new commit added

  • Require all fedmsg modules
8 years ago

I'm not familiar with the [all] notation - what does this do?

For PEP-8, there should be two spaces between this line and the import.

LGTM as is, or you can take my PEP-8 suggestion if you like.

It installs all the fedmsg requirements: https://github.com/fedora-infra/fedmsg/blob/develop/setup.py#L95

1 new commit added
8 years ago

Thanks for the review, I adjusted the pep8 violation.

Merging :)

Pull-Request has been merged by pingou
8 years ago
Metadata
None
No Tags
Changes Summary 3
+1 -1
file changed
README.rst
+19
file added
fedmsg.d/mdapi.py
+1 -1
file changed
requirements.txt
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.