mdapi

Clone
Source Code
GIT

#61 Import multidict from multidict instead of aoihttp
Merged 7 years ago by pingou. Opened 7 years ago by pingou.
fix_deps  into  master

file modified
+3 -2 
@@ -30,7 +30,8 @@ 
 

  

  import asyncio
 

  import werkzeug
 

- from aiohttp import web, MultiDict
 

+ from aiohttp import web
 

+ from multidict import MultiDict
 

  

  import mdapi.lib as mdapilib
 

  import mdapi.file_lock as file_lock
 
@@ -66,7 +67,7 @@ 
 

          :arg request: the request that was called that we want to add JSONP
 

          support to
 

          :type request: aiohttp.web_request.Request
 

-         

+ 

          '''
 

          response = yield from function(request, *args, **kwargs)
 

          url_arg = parse_qs(request.query_string)

file modified
+2 
@@ -1,5 +1,7 @@ 
 

  aiohttp
 

  fedmsg[all]
 

+ # this is a requirement of aiohttp but better safe than sorry
 

+ multidict 

  requests
 

  sqlalchemy
 

  werkzeug

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Looks fine although you might want to update the requirements.txt to reflect the dependency.

It's a dependency of aiohttp so should be fine but better safe than sorry so I'll add it :)

rebased
7 years ago

Pull-Request has been merged by pingou
7 years ago
Metadata
None
No Tags
Changes Summary 2
+3 -2
file changed
mdapi/__init__.py
+2 -0
file changed
requirements.txt
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.