PR#92: return content_type=application/javascript for jsonp request - mdapi

mdapi

#92 return content_type=application/javascript for jsonp request

Closed 5 years ago by pingou. Opened 5 years ago by karsten.

karsten/mdapi master into master

return content_type=application/javascript for jsonp request

Karsten Hopp • 5 years ago

1915842

mdapi/views.py

file modified

+1 -1

		`@@ -57,7 +57,7 @@`

		`output = await _expand_pkg_info(pkg, branch, repotype)`

		`- return web.json_response(output)`
		`+ return web.json_response(output, content_type='application/javascript',)`


		`async def list_branches(request):`

karsten commented 5 years ago

Fixes: https://teams.fedoraproject.org/project/community-fire-team/us/14
There is an error when checking the javascript console at: src.fedoraproject.org/rpms/bash

Signed-off-by: Karsten Hopp karsten@redhat.com

pingou commented 5 years ago

This would be correct if it was true, the output is not javascript, it is JSON and thus the current mimetype is correct :)

karsten commented 5 years ago

If we switch to request json instead, we'd get CORS problems.
I still wonder if we shouldn't return javascript here, although I don't know how many other apps rely on the current behaviour.

pingou commented 5 years ago

We can do both. Set the CORS header which allow to request JSON and have things work, and add support for JSONP (which is different than request JSON).

pingou commented 5 years ago

I'm going to close this one as we agree that this solution isn't correct :)

Thanks for your work though