There is more places, we raise exceptions, and for better handling, it would be good to raise own exceptions for better filtering and usage.
Metadata Update from @jscotka: - Issue tagged with: Prio1, RFE
Metadata Update from @psklenar: - Issue assigned to psklenar
@jscotka , @psklenar I see some exceptions were implemented. I couldn't find if any is missing, please let me know if you are aware about any.
Also please let me know what means "for better filtering and usage". How/where is it filtered? How is it used? I need to understand why build in python exceptions and error handlers are not used, and maybe document it accordingly. Thank you.
Hi @igulina, when we've created own exceptions, it helps us to filter it when using in other projects, like in check_module project: https://github.com/fedora-modularity/check_modulemd/blob/develop/check_modulemd.py#L44
and it also helps you whats happen, in case for example we raise some build in like attribute error, or something similar, it is sometimes confusing, and seems not to be related to MTF. and also it somethimes happen, that for example in case method not found it raises attribute error what can cause that in case we'll raise it, it catch also errors what we don't want to catch. for example also https://pagure.io/modularity-testing-framework/blob/master/f/moduleframework/module_framework.py#_100 it will not be clear without own exception whats happened there.
_ I couldn't find if any is missing, please let me know if you are aware about any. good question, what do you think? I feel its enough and we can add smth later on when needed
@jscotka, @psklenar thanks for the update. I believe we can close this issue.
Metadata Update from @igulina: - Issue close_status updated to: upstream - Issue status updated to: Closed (was: Open)