Shouldn't NoSortMapping be a subclass of collections.OrderedDict? AIUI that a dict is iterated in insertion order isn't guaranteed until Python 3.7, right?

flake8 flags these here (with the import-order plugin). I can fix them before applying (I'll rebase onto master anyway, so it's not a biggie).

Same thing about imports being flagged as above, I'll fix it when applying.

I'll probably move these to files beneath tests/files/.

Is there a reason for changing this one to print() but leaving the other log.info() a few lines above in place?

@otaylor, I'm waiting on an answer to my dict vs. collections.OrderedDict and print() vs. log.info() questions above. Other than these and the changes I mentioned I'd anyway, the PR looks good to me.

Shouldn't NoSortMapping be a subclass of collections.OrderedDict? AIUI that a dict is iterated in insertion order isn't guaranteed until Python 3.7, right?

it's guaranteed for CPython for 3.6, then made an official language feature for 3.7. Unless we want to support older Python 3 than any current Fedora or non-CPython in the near future, dict should be fine. What do you think?

Is there a reason for changing this one to print() but leaving the other log.info() a few lines above in place?

At this point, I can't reconstruct why I changed it to print - I think it was because it wasn't showing up in the pytest output. I'll change it back and push a new version with that and the imports reordered.

what about changing the style - import ordering, with the defaults, test_flatpak_generator.py ends up as:

import logging
import os
import sys
import tempfile
from unittest.mock import Mock, patch
from contextlib import contextmanager
from click.testing import CliRunner
import gi
gi.require_version('Modulemd', '1.0')  # noqa: E402                                                                                                           
from gi.repository import Modulemd
import pytest
import responses
import yaml
from _fedmod.cli import _cli_commands  # noqa: I100     

Which is sort of ridiculous - every 3rd party import is forced into it's own group. While with import_order_style = google, application_import_names = _fedmod in setup.cfg:

from contextlib import contextmanager
import logging
import os
import sys
import tempfile
from unittest.mock import Mock, patch
from click.testing import CliRunner
import gi
gi.require_version('Modulemd', '1.0')  # noqa: E402                                                                                                           
from gi.repository import Modulemd
import pytest
import responses
import yaml
from _fedmod.cli import _cli_commands  # noqa: I100   

Which is much more like I'd arrange the imports.

Shouldn't NoSortMapping be a subclass of collections.OrderedDict? AIUI that a dict is iterated in insertion order isn't guaranteed until Python 3.7, right?

it's guaranteed for CPython for 3.6, then made an official language feature for 3.7. Unless we want to support older Python 3 than any current Fedora or non-CPython in the near future, dict should be fine. What do you think?

You're right.

what about changing the style [...]
Which is sort of ridiculous - every 3rd party import is forced into it's own group. While with import_order_style = google, application_import_names = _fedmod in setup.cfg: [...]
Which is much more like I'd arrange the imports.

Good call. I've changed the configuration and fixed the places which get flagged now, but there are some conflicts now with the PR. Do you want to fix them or should I?

I've fixed the conflicts meanwhile and (as per my comment) also moved the test data to their own files.

Applied in commits abed17b..5f2f6e8