netcf

#1 dutil_posix.c:225]: (style) Suspicious condition
Opened by dcb. Modified

Open
Close Issue

dutil_posix.c:225]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

while ((waitret = waitpid(childpid, &exitstatus, 0) == -1) &&
       errno == EINTR) {

Maybe better code

while (((waitret = waitpid(childpid, &exitstatus, 0)) == -1) &&
       errno == EINTR) {

Thanks for the report, Eric sent a patch upstream: https://lists.fedorahosted.org/archives/list/netcf-devel@lists.fedorahosted.org/thread/XZHZVOOJJCOZGDOP4PYWPD7ZX4MKNPKV/
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.