#642 ODCS is generating composes with no `images.json` metadata file at all
Closed by adamwill. Opened by adamwill.

This morning, a few composes came out of ODCS which have no images.json metadata file at all, e.g. this one:

https://odcs.fedoraproject.org/composes/odcs-28803/compose/metadata/

This is new behaviour, I think. We've had composes that contain no images for a long time - like the updates and updates-testing composes - but those do have a kinda stub images.json file:

https://kojipkgs.fedoraproject.org/compose/updates/Fedora-39-updates-testing-20230831.0/compose/metadata/images.json

Not sure what's going on, but it seemed worth reporting. This caused problems for fedfind, which kinda doesn't expect this to happen; I'm extending it to handle this now.


@kevin for info

Has the configuration changed?
It's not particularly new behaviour: https://pagure.io/pungi/pull-request/1294
TLDR is that pungi doesn't create the file if all phases that could generate an image are skipped.
If they are not explicitly skipped and just don't create anything, an empty file will be created.

The reasoning for that was restarting a compose that failed to create some containers, and the skipped phases would write over a previously created file.

Ah, OK. If it's intended behaviour on pungi side I guess there's nothing to fix here, consumers just need to handle it (I already adjusted fedfind to do this).

Metadata Update from @adamwill:
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/pungi/odcs/issues/642

Please continue any further discussion there.

Metadata