PR#157: Add a hint for rejecting a push to disabled branch - pagure-dist-git - Pagure.io

pagure-dist-git

#157 Add a hint for rejecting a push to disabled branch

Merged 2 years ago by humaton. Opened 2 years ago by lenkaseg.

lenkaseg/pagure-dist-git eol into master

Add a hint for rejecting a push to disabled branch

Lenka Segura • 2 years ago

2e97c5e

dist_git_auth.py

file modified

+1 -1

		`@@ -247,7 +247,7 @@`
		`pdc_ref = branch_overrides[project.namespace][refname]`
		`is_supported = self.is_supported_branch(project, pdc_ref)`
		`if is_supported is False:`
		`- self.info("Branch %s is unsupported" % refname)`
		`+ self.info("Branch %s is unsupported. Cannot push to a disabled branch (maybe eol?)." % refname)`
		`return False`
		`elif is_supported is True:`
		`self.debug("Branch %s is supported" % refname)`

pagure_distgit_tests/test_dist_git_auth.py

file modified

+1 -1

		`@@ -470,7 +470,7 @@`
		`)`
		`)`

		`- self.expect_info_msg("Branch refs/heads/f26 is unsupported")`
		`+ self.expect_info_msg("Branch refs/heads/f26 is unsupported. Cannot push to a disabled branch (maybe eol?).")`

		`@patch("dist_git_auth.requests")`
		`def test_protected_supported_branch_committer(self, mock_requests):`

lenkaseg commented 2 years ago

Added explanation for rejected push from the reason of rpm branch being end-of-life.

Related to issue:
https://pagure.io/releng/issue/10299

Issue context:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/KKK5ES37BTWEMRDPJ3TRBVCUZH6ANTXS/

Metadata

Assignee

None

Tags

No Tags

Changes Summary 2

file changed

dist_git_auth.py

file changed

pagure_distgit_tests/test_dist_git_auth.py

Powered by Pagure 5.14.1

Documentation • File an Issue • About • SSH Hostkey/Fingerprint

© Red Hat, Inc. and others.