#41 Do not take forks into account when retrieving maintainers and watchers
Merged 7 years ago by pingou. Opened 7 years ago by pingou.

file modified
+4
@@ -69,6 +69,10 @@ 

          model.Project.id == model.Watcher.project_id

      ).filter(

          model.Watcher.user_id == model.User.id

+     ).filter(

+         model.Project.parent_id == None

+     ).filter(

+         model.Project.is_fork == False

      )

  

      for entry in query.all():

@@ -52,6 +52,10 @@ 

          model.Project.namespace, model.Project.name, model.User.user,

      ).filter(

          model.Project.user_id == model.User.id

+     ).filter(

+         model.Project.parent_id == None

+     ).filter(

+         model.Project.is_fork == False

      )

  

      output = collections.defaultdict(dict)
@@ -70,6 +74,10 @@ 

          model.ProjectUser.user_id == model.User.id

      ).filter(

          model.ProjectUser.access.in_(['commit', 'admin'])

+     ).filter(

+         model.Project.parent_id == None

+     ).filter(

+         model.Project.is_fork == False

      )

  

      for entry in query.all():

Otherwise we end up with people being considered while all they did was
to fork the project.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Ok tested in prod and seems to work as expected :)

Thanks for the review :)

Pull-Request has been merged by pingou

7 years ago