#48 Add support for commit flags in the commit view
Merged 7 years ago by pingou. Opened 7 years ago by pingou.

file modified
+28
@@ -130,6 +130,34 @@ 

      {% endif %}

  </div>

  

+ <section class="list-group" id="flag_list">

+   <div class="card" id="pr_flags">

+       <ul class="list-group list-group-flush">

+         {% for flag in flags %}

+           <li class="list-group-item">

+             <div>

+               <span>

+                 <a href="{{ flag.url }}">{{ flag.username }}</a>

+               </span>

+               <div class="pull-xs-right">

+                 <span class="label {{ flag | flag2label }}">

+                   {{ flag.status }}

+                   {%- if flag.percent %} ({{ flag.percent }}%) {%- endif %}

+                 </span>

+               </div>

+             </div>

+             <small><div class="clearfix">

+                 <span>{{ flag.comment }}</span>

+                 <div title="{{ flag.date_created }}" class="pull-xs-right">

+                 {{ flag.date_created | humanize }}</div>

+             </div>

+             </small>

+           </li>

+         {% endfor %}

+       </ul>

+     </div>

+ </section>

+ 

  {% set filecount = 0 %}

  {% for patch in diff %}

    {% set filecount = filecount + 1 %}

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto edaa38a2a032fd100ff939e1822d18abaa5dd603

7 years ago

I find the line breaking here kind of unfortunate, and hard to read. Maybe just do the newline between flag.percent %} and ({{?

rebased onto a27b5d4f6036fc2af2cb3f83ea7dd62ec62e33ba

7 years ago

rebased onto 98c4ae0

7 years ago

+1 and sorry for being so nitpicky over linebreaks :)

Pull-Request has been merged by pingou

7 years ago
Metadata