PR#52: Add a tag making it obvious when a package is retired on Fedora - pagure-dist-git

pagure-dist-git

#52 Add a tag making it obvious when a package is retired on Fedora

Merged 7 years ago by pingou. Opened 7 years ago by pingou.

mark_retired_packages into master

Small simplification of the JS code

Pierre-Yves Chibon • 7 years ago

3cd5456

Add a tag making it obvious when a package is retired on Fedora

Pierre-Yves Chibon • 7 years ago

ef745d1

template/repo_info.html

file modified

+11 -3

		`@@ -379,9 +379,8 @@`
		`$( "#pkgdescription" ).text(res['description']);`
		`if (res['url']){`
		`var _p = $('.projectinfo');`
		`- $('.projectinfo').html(`
		`- _p.html()`
		`- + ' (<a target="_blank" rel="noopener noreferrer" href="'`
		`+ $('.projectinfo').append(`
		`+ ' (<a target="_blank" rel="noopener noreferrer" href="'`
		`+ res['url'] + '"a>upstream</a>)')`
		`}`
		`}`
		`@@ -399,6 +398,13 @@`
		`branch = res.results[branch];`
		`var _it = $('#branch-' + branch.name);`
		`_it.addClass('disabled_branch');`
		`+ if (branch.name == 'master') {`
		`+ var _t = $('.projectinfo');`
		`+ html = ' \`
		`+ <div class="small label label-sm label-danger" data-toggle="tooltip" \`
		`+ title="This package has been retired">Retired on Fedora</div>';`
		`+ _t.append(html);`
		`+ }`
		`}`
		`if (res.next){`
		`get_branches(res.next);`
		`@@ -502,7 +508,9 @@`
		`});`
		`{% endif %}`

		`+ {% if repo.is_fork %}`
		`disable_branches();`
		`+ {% endif %}`

		`});`
		`</script>`

pingou commented 7 years ago

Fixes https://pagure.io/pagure-dist-git/issue/42

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

mprahl commented on line 18 of template/repo_info.html 7 years ago

projectinfo should likely be an ID instead of a class since it seems that there will only be one element that represents projectinfo per page.

mprahl commented on line 3 of template/repo_info.html 7 years ago

As a side note, this AJAX call doesn't seem to work on the latest Chrome on F27. I get the following error:

Refused to execute script from 'https://apps.fedoraproject.org/mdapi/rawhide/pkg/fedrepo-req?callback=jQuery110206692310512757702_1515685041918&_=1515685041919' because its MIME type ('application/json') is not executable, and strict MIME type checking is enabled

mprahl commented 7 years ago

A couple random comments but they aren't blocking. +1

pingou commented on line 18 of template/repo_info.html 7 years ago

That comes from a different template which I'd rather not change, so I'll leave this in for now.

2 new commits added