#62 Make it so SIGs don't require a dash
Merged 6 years ago by pingou. Opened 6 years ago by puiterwijk.
puiterwijk/pagure-dist-git no-sig-require-dash  into  master

file modified
+1 -1
@@ -212,7 +212,7 @@ 

              # Allow CentOS SIGs to push to e.g. c7-sig-core-$anything

              for signame in user_sigs:

                  for sigprefix in self.sig_prefixes:

-                     sigbranch = "%s-%s-" % (sigprefix, signame)

+                     sigbranch = "%s-%s" % (sigprefix, signame)

                      if refname.startswith(sigbranch):

                          self.debug("SIG push")

                          return True

LGTM - is there a test suite for this repo? If so, a test might be good, if not, this is a simple enough change.

There is a test suite in this repo, I've just opened https://pagure.io/pagure-dist-git/pull-request/63 to make it work with the latest code from pagure

I have the test for this PR ready, I'll just merge this PR here and add the new test in #63 or in another PR if people prefer.

Pull-Request has been merged by pingou

6 years ago
Metadata