#17 Support Trac attachment import to pagure
Merged by cverna. Opened by cverna.
cverna/pagure-importer add_attachments  into  master

Download 17.patch

Fixing https://pagure.io/pagure-importer/issue/15

1 new commit added

  • Create a comment issue when we have just an attachment

8 new commits added

  • Create a comment issue when we have just an attachment
  • Attachment from fedorahosted are now included in the
  • Adding Attachment to comment
  • Pushed changes to attachment managment
  • Add the issue hash to attachment filename
  • Commit attached files in the cloned ticket repository
  • Changed how we get tags
  • Manage trac attachment

1 new commit added

  • Remove debug print statement

The name of the file in the git repo is its sha + a secure version of its name: https://pagure.io/pagure/blob/master/f/pagure/lib/git.py#_618-621

You likely want to keep comments=None in the function declaration even if you do just below: comments = comments or [] as otherwise you end up with the risk of running into http://effbot.org/zone/default-values.htm

2 new commits added

  • Changed the way the attachment filename is build
  • Create a somebody user for comment, pagure does not support anonymous comment

1 new commit added

  • Added missing module to requirements.txt

@cverna i am getting connection refused here at this step pgimport fedorahosted https://fedorahosted.org/foobar. I was trying for fedocal. Probably because, it needs some permission which i don't have. Maybe @pingou can verify this pr after he gets free.

@vivekanand1101 humm you should not need permission for fedocal. I am pretty sure I don't have any and I am able to get tickets form fedorahosted.org/fedocal

Are you sure you have entered your correct FAS username and password ?

Ok, so this one works. Sorry for bothering, It was problem from my side which won't happen anymore. I just have one question: iirc, i saw @puiterwijk talk about different ticket statuses on trac, some roughly equivalent to ones in pagure. Do we want to label them accordingly? I am fine with just open/fixed.

Thanks for the test @vivekanand1101 . @pingou @puiterwijk what do you think about the ticket statuses ? For now I consider anything else than closed in Trac as open in Pagure.

@cverna we can take statuses like @puiterwijk did: http://paste.fedoraproject.org/380165/66096704/
But, i have no idea what resolution is though. :/

@vivekanand1101 I ll make this change in another PR.
So I can merge this one, and let people play with it :smile:

Pull-Request has been merged by cverna

Metadata