From 4beb849715cb2c6164e2b74d5acf5c24e21b881f Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Sep 12 2016 10:58:03 +0000
Subject: Add the opportunity to list all issues, opened and closed


Fixes https://pagure.io/pagure/issue/1288

---

diff --git a/pagure/templates/issues.html b/pagure/templates/issues.html
index 2fed964..b4b1cc1 100644
--- a/pagure/templates/issues.html
+++ b/pagure/templates/issues.html
@@ -39,31 +39,33 @@
 
 <section id="tags">
   <span class="btn-group btn-group-sm issues-tagbar" role="group" aria-label="Basic example">
-    {% if status and status != 'Open' %}
-      <a class="btn btn-secondary btn-sm" href="{{ url_for('view_issues',
-        repo=repo.name,
-        username=username,
-        namespace=repo.namespace,
-        tags=tags, author=author, assignee=assignee) }}">Open</a>
-      <a class="btn btn-primary btn-sm" href="{{ url_for('view_issues',
-        repo=repo.name,
-        username=username,
-        namespace=repo.namespace,
-        status='Closed', tags=tags, author=author,
-        assignee=assignee) }}">Closed</a>
-    {% else %}
-      <a class="btn btn-primary btn-sm" href="{{ url_for('view_issues',
-        repo=repo.name,
-        username=username,
-        namespace=repo.namespace,
-        tags=tags, author=author, assignee=assignee) }}">Open</a>
-      <a class="btn btn-secondary btn-sm" href="{{ url_for('view_issues',
-        repo=repo.name,
-        username=username,
-        namespace=repo.namespace,
-        status='Closed', tags=tags, author=author,
-        assignee=assignee) }}">Closed</a>
-    {% endif %}
+      <a class="btn {%
+        if status|lower in ['open', 'true'] %}btn-primary{%
+        else %}btn-secondary{%
+        endif %} btn-sm" href="{{ url_for('view_issues',
+          repo=repo.name,
+          username=username,
+          namespace=repo.namespace,
+          tags=tags, author=author,
+          assignee=assignee) }}">Open</a>
+      <a class="btn {%
+        if status|lower in ['closed', 'false'] %}btn-primary{%
+        else %}btn-secondary{%
+        endif %} btn-sm" href="{{ url_for('view_issues',
+          repo=repo.name,
+          username=username,
+          namespace=repo.namespace,
+          tags=tags, author=author, status='Closed',
+          assignee=assignee) }}">Close</a>
+      <a class="btn {%
+        if status|lower in ['all', 'none'] %}btn-primary{%
+        else %}btn-secondary{%
+        endif %} btn-sm" href="{{ url_for('view_issues',
+          repo=repo.name,
+          username=username,
+          namespace=repo.namespace,
+          tags=tags, author=author, status='all',
+          assignee=assignee) }}">All</a>
   </span>
   <span class="oi m-l-2" data-glyph="tag"></span>
   <span class="btn-group btn-group-sm issues-tagbar" role="group" aria-label="Basic example">
@@ -143,7 +145,7 @@
         <tr>
             <td>
               <span class="label label-default">#{{ issue.id }}</span>
-              {% if status and status != 'Open' %}
+              {% if status != 'Open' %}
               <span class="label {% if
                 issue.status|lower == 'invalid' %}label-danger{%
                 elif issue.status|lower == 'fixed' %}label-success{%
diff --git a/pagure/ui/issues.py b/pagure/ui/issues.py
index d538d60..b6edb11 100644
--- a/pagure/ui/issues.py
+++ b/pagure/ui/issues.py
@@ -400,7 +400,7 @@ def remove_tag(repo, username=None, namespace=None):
 def view_issues(repo, username=None, namespace=None):
     """ List all issues associated to a repo
     """
-    status = flask.request.args.get('status', None)
+    status = flask.request.args.get('status', 'Open')
     priority = flask.request.args.get('priority', None)
     tags = flask.request.args.getlist('tags')
     tags = [tag.strip() for tag in tags if tag.strip()]
@@ -426,6 +426,9 @@ def view_issues(repo, username=None, namespace=None):
     if flask.g.repo_admin:
         private = None
 
+    if str(status).lower() in ['all']:
+        status = None
+
     oth_issues = None
     if status is not None:
         if status.lower() == 'closed':
@@ -464,11 +467,9 @@ def view_issues(repo, username=None, namespace=None):
 
     else:
         issues = pagure.lib.search_issues(
-            SESSION, repo, status='Open', tags=tags, assignee=assignee,
+            SESSION, repo, tags=tags, assignee=assignee,
             author=author, private=private, priority=priority)
-        oth_issues = pagure.lib.search_issues(
-            SESSION, repo, closed=True, tags=tags, assignee=assignee,
-            author=author, private=private, priority=priority, count=True)
+        oth_issues = []
 
     tag_list = pagure.lib.get_tags_of_project(SESSION, repo)