Learn more about these different git repos.
Other Git URLs
Some projects are configured to require a sign-off in commits. It is possible to add a note about this above the new PR form. However, occasionally people still open pull requests without it.
In such situation, the merge button is not shown at all (not green nor red), so the maintainer can use this as indication that the sign-off is probably missing.
It would be great if the page displayed this information more prominently, and if the information was available to people without commit access as well.
@lsedlar, we currently don't have sign-off feature in pagure. Is this a feature request? I doubt pygit2 itself supports sign off feature.
@vivekanand1101, we do support in two ways:
a) a plugin blocking pushes of commits not having said 'signed-off-by'
b) a check in the code for PR preventing them to be merged if they are not signed off.
@lsedlar, maybe you could set a customizing the PR page to make things more prominent? https://docs.pagure.org/pagure/usage/pr_custom_page.html
ah. I shouldn't be allowed to comment :/ :cry:
ah. I shouldn't be allowed to comment
You are most welcome to do so, now you know and with your contributor status you can even look at what can be done to close this ticket ;-)
Commit f8c6ddb fixes this issue
Log in to comment on this ticket.