pagure

#1141 Limit html5lib version to be compatible with latest bleach lib (1.4.3)
Closed: Fixed Opened by tiagovieira.

Closed: Fixed
Reopen Issue

Latest release from html5lib removed the sanitizer module, breaking the bleach library.

Sanitizer Ref: https://github.com/html5lib/html5lib-python/issues/72
Bleach Ref: https://github.com/mozilla/bleach/commit/d0b3af80c723a0407e6dad8e6b2070829aef8f07

There are two ways to solve it for now:
1. Remove html5lib from the requirements.txt leaving it to be installed as dependency of bleach
2. Add the limiting into the requirements.txt (for instance, html5lib>=0.999,<0.99999999)

(EDITED) I vote for the option 1. (sorry, I wrongly said I voted for option 2)

We experienced this same issue in fedora-hubs project. One of the concerns with limiting the version in requirements.txt is that it's a security risk since new patches won't be included (credit puiterwijk for making me aware of that). How we dealt with this is if someone ran into an issue we asked them to downgrade html5lib to the latest known working one in the project. It's unfortunate that html5lib is breaking api stability and also have awful number versioning.

WE can eliminate this problem by removing html5lib from the requirements.txt then. That way we leave to the bleach project to control what version best suits them through pip install.

wfm, lets see what pingou and ryan have to say about this. I would assume they would be okay with removing.

Edited by skrzepto

Fixed in https://pagure.io/pagure/pull-request/1142

@pingou changed the status to Fixed
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.