Learn more about these different git repos.
Other Git URLs
In Pungi, we have the Pagure hook enabled. As I understand it, when pull request is merged, something should happen if there are references to issues.
Today I merged a pull-request containing a commit containing what I consider a valid reference. Nothing happened on the issue.
Is my understanding incorrect or is there something going wrong?
I think it has to contain the url of the issue and not only the number.
In your case it would look like : Fixes https://pagure.io/pungi/issue/398
I did try with full URL and nothing happened either: PR, commit and issue.
It should work with the full URL or just the #<id> as you did. I'm trying to investigate.
I can only think of two things:
Looking at the project, it looks fine, so it's something else.
@lsedlar could you maybe try to do the push manually to see what it says on the console?
The push happens to a fork. I tried enabling the hook on the fork as well, but nothing changed. There are no references to issues in the console output:
$ git push origin reduce-version-duplication Counting objects: 4, done. Delta compression using up to 4 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 551 bytes | 0 bytes/s, done. Total 4 (delta 3), reused 0 (delta 0) remote: Emitting a message to the fedmsg bus. remote: New reference/branch remote: * Publishing information for 1 commits remote: *fedmsg start To ssh://git@pagure.io/forks/lsedlar/pungi.git * [new branch] reduce-version-duplication -> reduce-version-duplication
I tried to push the commit again but with reference via URL. Nothing changed.
$ git push origin reduce-version-duplication -f Counting objects: 4, done. Delta compression using up to 4 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 573 bytes | 0 bytes/s, done. Total 4 (delta 3), reused 0 (delta 0) remote: Emitting a message to the fedmsg bus. remote: * Publishing information for 1 commits remote: *fedmsg start To ssh://git@pagure.io/forks/lsedlar/pungi.git + 20eeb53...ac635a0 reduce-version-duplication -> reduce-version-duplication (forced update)
hm, looking at the hook, it's only actually being run when push are made to the main branch (ie: master most of the time), so here we don't have much output.
I wonder if this isn't fixed by https://pagure.io/pagure/pull-request/2791
@lsedlar did you observe this again recently?
The last update was 5 years ago, no further requests, updates or actionable tasks since then, I'm going to close this issue for now to reduce our backlog.
Metadata Update from @wombelix: - Issue close_status updated to: Insufficient data - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.