#1338 Assigning issue to milestone not displayed immediately
Closed: Fixed 7 years ago Opened 8 years ago by lsedlar.

Steps to reproduce:

  1. Open an issue
  2. Click Edit metadata
  3. Select any milestone
  4. Click Update
  5. Page still shows empty milestone
  6. Refresh page
  7. See milestone filled in

I would expect this should behave the same as when changing status or assignee; where the page shows correct values immediately after clicking Update.


Actually, there is somewhat similar problem with removing tags. If two tags are removed at the same time, only one of them disappears after clicking Update. On refresh both are gone.

For milestone it's not surprising, the SSE code does not handle them anymore since we stopped relying on tags for milestone.

We need to fix this :)

@lsedlar hey i tried removing two tags at the same time and clicked 'Update', it worked well for me. Wondering why only one disappears for you.

I have no idea what's going wrong here. I tried it again on an issue with two tags. When I remove them both from the form and click Update, a POST request to update?js=1.

The browser JS console prints this:

<form action="/lsedlar-test-playground/issue/4/update" method="post" onsubmit="return try_async_comment(this)">          4:871:3
true                                                                                                                     4:861:3
POST XHR https://pagure.io/lsedlar-test-playground/issue/4/update                                        [HTTP/1.1 200 OK 747ms]
{"removed_tags": ["v0.0", "v0.1"]}                                                                                       4:847:3
Object { removed_tags: Array[2] }                                                                              issue_ev.js:250:3
removing v0.0,v0.1                                                                                              issue_ev.js:32:3
false                                                                                                                    4:861:3

But both tags are still shown. On full page reload it's fixed and no tag is displayed.

Trying to replicate this now, it seems it has been fixed :)

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue set to the milestone: None (was: None)

7 years ago

Log in to comment on this ticket.

Metadata