Issue #1566: `tests/__init__.py` calls `pagure.lib.model.drop_tables`, which doesn't exist - pagure

pagure

#1566 `tests/init.py` calls `pagure.lib.model.drop_tables`, which doesn't exist

Closed: Fixed Jan 9, 2017 Opened Nov 16, 2016 by adamwill.

In the course of working on #1565, I found one pylint no-member error which is entirely valid. The tearDown function in tests/__init__.py has this line:

            pagure.lib.model.drop_tables(DB_PATH, self.session.bind)

there is no drop_tables function in pagure.lib.model.

This probably hadn't been noticed as no-one's using a local pgsql database when running tests, I guess.

pingou commented Nov 16, 2016

I'd be in favor of just dropping these lines indeed, not point in keeping them.

pingou commented Jan 9, 2017

Fixed by @amolkahat in #1716

@pingou changed the status to Closed

Jan 9, 2017

Metadata

Assignee

None

Tags

Blocking

None

Depending on

None

Priority

None

pagure

#1566 `tests/__init__.py` calls `pagure.lib.model.drop_tables`, which doesn't exist Closed: Fixed Jan 9, 2017 Opened Nov 16, 2016 by adamwill.

Metadata

bug easyfix

#1566 `tests/init.py` calls `pagure.lib.model.drop_tables`, which doesn't exist

Closed: Fixed Jan 9, 2017 Opened Nov 16, 2016 by adamwill.