Issue #1746: Removing a tag from an issue removes the tag from the database - pagure

pagure

#1746 Removing a tag from an issue removes the tag from the database

Closed: Fixed Jan 16, 2017 Opened Jan 12, 2017 by mreynolds.

If there is only one issue that uses a particular tag, and you remove that tag from the issue. The tag is completely removed from the project and lost forever. Updating an issue should never modify a project's tags.

This looks like the old global tag behaviour is still present in regards to removing tags from issues.

mreynolds commented Jan 12, 2017

@pingou - looks like you broke this when you rewrote my fix. I'm not sure what you did, but if you delete a tag from an issue it completely removes the tag from the project. Looking at the code you really rewrote a lot of what I did, so I'm not sure how to fix it without going back to my original fix. It looks like you made tags specific to issues, and not independent of issues (which goes against the core idea behind my original fix).

Can you please look into this?

Thanks,
Mark

pingou commented Jan 13, 2017

Sorry for the troubles, I will look into this :)

mreynolds commented Jan 13, 2017