pagure

#3377 Unable to assign pull requests
Closed: Fixed Opened by wattersmt.

Closed: Fixed
Reopen Issue

The option to assign or tag a pull request is missing from the overview tab. This is happening after upgrading to the 4.0.3 release. Here is a screenshot for reference.

https://i.imgur.com/rtDapTg.png

@wattersmt Thanks for the issue report!

Just for some further information, what is the privileges of the user you are viewing this page with? You should be easily able to view the privs by looking at the user list on the overview page for the repo in question. (it should be admin, commit, or ticket) IIRC. Or does your user show up in the user list at all on the overview page?

@ryanlerch My account has admin access on this project. I'm able to access the settings page and change settings as needed.

Also, I'm seeing some strangeness in the logs.

[Thu Jun 28 12:03:03.549214 2018] [:error] [pid 23973] 2018-06-28 12:03:03,548 [INFO] pagure.ui.fork: Viewing pull Request #49 repo: puppet
[Thu Jun 28 12:03:04.956162 2018] [:error] [pid 23973] 2018-06-28 12:03:04,922 [INFO] pagure.lib.git: None asked to diff the pull-request: PullRequest(49, project:puppet, user:michael.watters, title:Change - Update samba settings for plant utility servers)
[Thu Jun 28 12:03:04.960332 2018] [:error] [pid 23973] 2018-06-28 12:03:04,960 [INFO] pagure.lib.git:   working directory: /var/tmp/pagure-pr-mergeQSU1J1
[Thu Jun 28 12:03:07.424129 2018] [:error] [pid 23973] 2018-06-28 12:03:07,423 [INFO] pagure.lib.git:   1 commit to merge
[Thu Jun 28 12:03:07.497670 2018] [:error] [pid 23973] 2018-06-28 12:03:07,497 [INFO] pagure.lib.git:   Adding remote: michael.watters_0adcf422cb4c4a40a630ed0a2479367c pointing to: /srv/git/repositories/puppet.git
[Thu Jun 28 12:03:07.614874 2018] [:error] [pid 23973] 2018-06-28 12:03:07,614 [INFO] pagure.lib.git:   PR merged using fast-forward, reporting it
[Thu Jun 28 12:03:22.174073 2018] [:error] [pid 23973] 2018-06-28 12:03:22,173 [INFO] pagure.ui.fork: Viewing pull Request #49 repo: puppet

Why does it say "None" asked to diff the pull request?

I believe I have found a fix. The following diff allows PRs to be assigned and tagged as expected.

--- pull_request.html.old   2018-06-28 12:45:30.711011930 -0400
+++ pull_request.html   2018-06-28 12:48:25.683400951 -0400
@@ -738,7 +738,7 @@
     <div class="card">
       <div class="card-block">
-        {% if authenticated and mergeform and pull_request.status == 'Open'
+        {% if g.authenticated and mergeform and pull_request.status == 'Open'
             and g.repo_committer %}
           <form method="POST" action="{{ url_for('ui_ns.update_pull_requests',
               repo=repo.name,
@@ -790,7 +790,7 @@
             </h4>
         </fieldset>
-        {% if authenticated and mergeform and pull_request.status == 'Open'
+        {% if g.authenticated and mergeform and pull_request.status == 'Open'
                 and (g.repo_committer
                     or g.fas_user.username == pull_request.user.user) %}

I believe this has been fixed in git, how did you come up with this patch? (which looks good btw :))

As far as I can see, it's fixed in git, so I'm going to close this ticket as such.

Please do re-open it, if it's not the case for you :)

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue tagged with: bug
Metadata
None

bug

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.