Issue #3684: PR code updated (new commits) Web Hook Event not sent (until I refresh the PR page) - pagure

pagure

#3684 PR code updated (new commits) Web Hook Event not sent (until I refresh the PR page)

Closed: Fixed Dec 10, 2018 Opened Sep 24, 2018 by fbo.

I'm working on an integration between Zuul and Pagure. The driver heavily relies on the Web Hook system of pagure.

I figured out than when I update a PR by adding new commits to the PR the event is not sent until I refresh the related PR page. Note that the pagure instance I'm using is pagure.io.

It looks like a bug, I expect to receive the event a soon as the PR is updated.

Metadata Update from @pingou:
- Issue set to the milestone: 5.1

Sep 25, 2018

Metadata Update from @pingou:
- Issue assigned to pingou

Oct 3, 2018

Metadata Update from @pingou:
- Issue tagged with: bug

Oct 3, 2018

pingou commented Oct 5, 2018

Commit 9742019b fixes this issue

Metadata Update from @fbo:
- Issue status updated to: Open (was: Closed)

Oct 23, 2018

fbo commented Oct 23, 2018

I'm receiving notification when a PR commented but not when a new commit is added. So it looks like it is not fixed then I reopen the issue.

fbo commented Oct 23, 2018

I'm receiving notification when a PR commented but not when a new commit is added. So it looks like it is not fixed then I reopen the issue.

Also receiving when the PR is created, but not the PR is updated (new commit)

Edited Nov 14, 2018 by pingou

Metadata Update from @pingou:
- Issue set to the milestone: 5.2 (was: 5.1)

Oct 24, 2018

pingou commented Nov 14, 2018

Just to be sure, you know that notifications about a PR being updated/rebased will appear in the form a comment, right?

fbo commented Nov 14, 2018

Yes I known that. The problem is I don't receive the comment notification since the 5.1.

pingou commented Nov 14, 2018

Yes I known that. The problem is I don't receive the comment notification since the 5.1.

Could you give me more details about the project? Locally things seems to work.

fbo commented Nov 14, 2018

It is https://pagure.io/test-zuul. I'll re-try again asap (tomorrow). I keep you updated there.

fbo commented Nov 15, 2018

Yes I confirm. New commit added = no event. https://pagure.io/test-zuul/pull-request/29

pingou commented Dec 10, 2018

I believe this has been fixed in #4012 and #4013, for some reasons the change got undone so https://pagure.io/pagure/pull-request/4113 fixes this again :)

fbo commented Dec 10, 2018

First tests show it is fixed. I think we can close the issue.

fbo commented Dec 10, 2018

Well when https://pagure.io/pagure/pull-request/4113 is merged.

pingou commented Dec 10, 2018

Commit c811a248 fixes this issue