Learn more about these different git repos.
Other Git URLs
On https://pagure.io/test-zuul, setting "Minimum score to merge " is set on 2. The pull-request/3 have more than 2 thumbsup on multiple comments but merge is impossible "This request does not have the minimum review score necessary to be merged".
ah, I see the vote are casted using :thumbsup: or :thumbsdown: reactions are not taken inot account
No sure to understand. On the PR 3 I have a score a 3 right ? Is it the computation server side that is not done the same way ?
Where do you see a score of 3 in https://pagure.io/test-zuul/pull-request/3 ?
From the doc, I'm reading that "If this option is enabled, anyone can vote in favor or against a pull-request and the sum of the votes in favor minus the sum of the votes against give the pull-request a score that should be equal or greater than the value entered in this option for the pull-request to be allowed to be merged." So I understand 4 upvote - 1 downvote -> score = 3 Then I should be able to merge.
Except that as I said, votes are casted using emojis: :thumbsup: and :thumbsdown: not using reactions
Ok, I got it :) Now I have 3 :thumbsup: but still I can't merge. Is there any restrictions about the identity of the person that added :thumbsup: and :thumbsdown: to the comment ? I've rechecked "https://docs.pagure.org/pagure/usage/project_settings.html#activate-minimum-score-to-merge-pull-request", especially the notes boxes but I see nothing relevant to explain why I cant' merge.
Is there any restrictions about the identity of the person that added 👍 and 👎 to the comment
Note as far as I could see in the code, this sounds like a bug we should look into.
Metadata Update from @pingou: - Issue set to the milestone: 5.1 - Issue tagged with: bug
Thanks for the update. I'm happy to that scheduled for the 5.1 \o/
Ok, the code is smart enough that it enforces that multiple person vote on the PR :)
So there can't be just one person adding 3 :thumbsup: ;-)
Wonderful \o/ PR3 is now merged. Thanks ! So the doc deserve an update to explain that :)
Want to do it? :)
Metadata Update from @pingou: - Issue untagged with: bug - Issue tagged with: doc, easyfix
https://pagure.io/pagure/pull-request/3814
Commit 6937b66 relates to this ticket
Fixed in https://pagure.io/pagure/pull-request/3814
Metadata Update from @pingou: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.