#3940 Manually merged PR still open and with green merge button
Closed: Fixed 6 years ago Opened 6 years ago by lsedlar.

PR in question: https://pagure.io/pungi/pull-request/1072

I reformatted the commit message and some code and merged the patch outside of Pagure. Then I pushed master branch to Pagure. The usual Merges: … is in the commit message. Pagure hook was enabled in the repo.

The commit now appears on master branch, but the PR is still opened and I see a Merge button that claims it can be merged via fast-forward. That's not even true, there's a merge conflict.


Ok, the issue is that pungi was one of the early projects created on pagure.io, which means it got a post-receive file instead of the symlink as a result it still running the old-type post-receive hook instead of the new one.
I have a script to fix this but I don't want to run it while we're in freeze.

In the meantime I fixed pungi manually so it works for you (please let me know if it is or not).

Sorry for the troubles

Metadata Update from @pingou:
- Issue tagged with: bug

6 years ago

No problem, thank you. Once I get to test it I'll report the results.

Metadata Update from @pingou:
- Issue assigned to pingou

6 years ago

Tested today, and it works correctly. Thank you very much!

A couple observations which are probably not problems:

  • the console output of git push showed Detailed log as output of repr, things like remote: (u'*', u'commit 12f949fe84fc036c6211bce346f41fa61c1da8a9')
  • notification of the push appeared on #pagure IRC channel, probably because I referenced the PR by full URL.

Metadata Update from @lsedlar:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

the console output of git push showed Detailed log as output of repr, things like remote: (u'*', u'commit 12f949fe84fc036c6211bce346f41fa61c1da8a9')

Yes, we still have debugging turned on, we will turn it off in a near future :)

notification of the push appeared on #pagure IRC channel, probably because I referenced the PR by full URL.

The logic behind IRC notifications is quite simple so that could be it yes

Log in to comment on this ticket.

Metadata